4.0/31324 #13
Merged
4.0/31324 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anything using $gray-600 is getting the color from the bs5 variables.scss ``` $text-muted: $gray-600 !default; $form-text-color: $text-muted !default; ``` This is not a contrast problem when the background color is white but if the background is the blue pattern then the color ratio fails One place where this is used is the alias description  I am not sure why but we are overriding the bs5 default colors for the $gray-* variables nor why the $gray-600 was commented out This PR uncomments the gray-600 variable and changes it slightly so that the contrast is valid on both the white and blue backgrounds
* reflow login page on small screens * add bottom margin Co-authored-by: Quy <quy@fluxbb.org>
* Lyout for GroupedlistField * plg Page Cache fancy layout * Apply suggestions from code review Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Brian Teeman <brian@teeman.net>
Following the advice of this PR ensures that the modules on the cpanel (dashboard) have four rounded corners and not two
Version 5.8.1 - May 20, 2021 Fixed An unexpected exception was thrown when switching to readonly mode and adjusting the editor width. Content could be lost when the pagebreak_split_block setting was enabled. The list-style-type: none; style on nested list items was incorrectly removed when clearing formatting. URLs were not always detected when pasting over a selection. Patch contributed by jwcooper. Properties on the OpenNotification event were incorrectly namespaced.
I made a mistake when creating the editor.scss joomla#33112 and I set the margins to 0 - really surprised no one spotted it either then or now. This PR puts the margin back as TinyMCE intended it to be ### Before ### After
…4205) * Fieldsets changed to h3 in tfa/totp * Fieldsets changed to h3 in tfa/yubikey * reduce scope of fieldset to the form and subforms only for edit user tfa * reduce fieldset scope to 2fa dropdown only * remove fieldset from user edit 2fa * revert parent fieldset removal * place hr before heading * place hr before heading for totp * place hr before otp heading in user edit
This pr adds the rel=noopener noreferrer to the link and makes the link open in a new tab. This is perfectly valid as you are opening information that is intended to be read accompanying the current page.
The email icon used had the wrong name (icon-envelope) it should have been (icon-mail) The icons are actually the same - the difference is that icon-mail has a color applied to it.
* Update _global.scss
* lint
The following pattern is not considered a violation:
a { --x: 0px; }
* Update _global.scss
* usermenu changed
made usermenu style consistent with others and removed styling from joomlaversion
* Update _global.scss
* Update administrator/templates/atum/scss/blocks/_global.scss
Co-authored-by: Quy <quy@fluxbb.org>
* Update administrator/templates/atum/scss/blocks/_global.scss
Co-authored-by: Quy <quy@fluxbb.org>
Co-authored-by: Quy <quy@fluxbb.org>
In the required section of the pre-update check there are three requirements that have some extra information available if the requirment is not met. Currently they are completely inaccessible as they are a title on a non-focusable element. There really isnt a good reason for this information not to be visible by default when it should be displayed
On a multilingual website on the menu dashboard each of the default menus for a language has the language code (or flag) displayed after the Menu name. This PR moves the language out of the link to avoid the ugly underline between the menu name and the language part
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
* [4.0] Changing title to tooltip fpr template preview
No idea how this was missed but this adds the character count to the meta description field when creating a menu item
Content versions for an article has a button to indicate if the version should be kept forever or not. However it is incorrectly an `a` link designed to look like a button but not act like a button. If the action is to take you to a new page then its a link - otherwise its a button. A button can be activated with both the space and enter keys. A link just by the enter key. BONUS: This also fixes joomla#34592
…and terms and conditions fields (joomla#34537)
The toolbar in the media manager is sticky but it has no background. This simple PR adds a solid white background (just as it has in the cassiopeia template. To test rebuild the css and make sure you have enough images in media manager to make it scroll. You will see there is no background on the toolbar when you scroll and you can see the images underneath it Apply this PR and repeat and you now have a solid background
To test make sure the version in the plugin matches the version numbers below ### Codemirror 21-06-2021: Version 5.62.0: lint addon: Add support for highlighting lines with errors or warnings. Improve support for vim-style cursors in a number of themes. ### Tinymce Version 5.8.2 - June 23, 2021 Fixed an issue when pasting cells from tables containing colgroups into tables without colgroups. Fixed an issue that could cause an invalid toolbar button state when multiple inline editors were on a single page.
…la#34620) * Hide the clear button when no value is set in media field * Remove duplicate code
* view overflow fixed * (UI overfow) compatibility issue update * revised(overflow auto added)
Deprecates an unused layout as requested joomla#34601 (comment)
…omla#34597) * Change the select all toggle to a checkbox in media manager * More merge conflicts fixed * Correct border * Listen on click * CS * Only stop propagation * code style
Change the title for transitions and stages to a tip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required