-
Notifications
You must be signed in to change notification settings - Fork 21
Assorted fixes #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted fixes #57
Conversation
|
I understand that this is a rather large change to the project; feel free to discuss the work if you're unclear about certain things or if you outright disagree :) |
|
👍 for |
|
@datibbaw Thanks, this makes easy to maintain extension and publishing as PECL. |
|
I know I'm a couple of months late on this, but can I get a reminder for the logic behind adding the |
|
@rdlowrey From what I can remember, this library has always been dependent on sockets; i.e. it won't compile without it. |
This is a collection of fixes that should improve the likelihood of it being picked up by package maintainers; it also includes a few memory fixes.
Package / build changes:
libuv; instead, link against an installation using--with-uv[=DIR]; it doesn't yet assert a particular version, it won't build on 0.12 so that needs fixing later on.--enable-httpparseris used and make sure it builds with and without. I've created two separate source files for ease of maintenance. Later on we could separate it into its own module (but still within the same extension).clangdidn't like those.socketsextensions inconfig.m4.Bug fixes:
EXPECTF.uv_cwd()anduv_exepath(); it also uses theMAXPATHLEN.