Fix opendir/readdir returning no entries when drivers have major/minor device numbers#33
Merged
JohnAmadis merged 2 commits intomainfrom Mar 10, 2026
Merged
Conversation
…ory to match subdirectories Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix dmdevfs to list directories in main path
Fix opendir/readdir returning no entries when drivers have major/minor device numbers
Mar 10, 2026
JohnAmadis
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compare_driver_directoryused exact-match between the listed path and a driver's parent directory. Drivers with major+minor numbers (e.g. pathdmgpio8/1, parentdmgpio8/) never matched when listing/, soget_next_driver_nodealways returnedNULL.Changes
compare_driver_directory: extended from exact-match to prefix-match. Root"/"now matches all drivers; any other path matches drivers whose parent starts withpath + "/".read_next_subdir_name(new helper): given the listing base path and a driver's parent path, extracts the correct immediate child name:readdirelse branch: replacedread_dir_name_from_path(parent_dir, ...)withread_next_subdir_name(dir_node->directory_path, parent_dir, ...)so subdirectory entries always resolve to the correct depth-relative name instead of the leaf of the full parent path.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.