Skip to content

Align release packaging with dmgpio to prevent empty release archives#5

Merged
JohnAmadis merged 2 commits into
mainfrom
copilot/release-pipeline-fix
May 29, 2026
Merged

Align release packaging with dmgpio to prevent empty release archives#5
JohnAmadis merged 2 commits into
mainfrom
copilot/release-pipeline-fix

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 29, 2026

Release artifacts in dmuart were being published as effectively empty packages. This PR aligns the release packaging behavior with dmgpio so archives are built from real build outputs, not fallback-created directories.

  • Problem scope

    • release.yml created package directories during archive assembly, which allowed zipping placeholder content when expected build-generated package directories were missing.
  • Change made

    • Removed directory creation in the release archive step:
      • mkdir -p "$BUILD_DIR/packages/dmuart"
      • mkdir -p "$BUILD_DIR/packages/dmuart_port"
    • Packaging now assumes and uses the package directories produced by the build pipeline, matching dmgpio’s release workflow contract.
  • Resulting behavior

    • Release ZIPs are generated from actual package contents under build_$BUILD_NAME/packages/..., avoiding silent creation of minimal/empty archives.
# before
mkdir -p "$BUILD_DIR/packages/dmuart"
echo "${{ github.event.release.body }}" > "$BUILD_DIR/packages/dmuart/RELEASE_NOTES.txt"

# after
echo "${{ github.event.release.body }}" > "$BUILD_DIR/packages/dmuart/RELEASE_NOTES.txt"

Copilot AI linked an issue May 29, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix release pipeline to ensure packages are not empty Align release packaging with dmgpio to prevent empty release archives May 29, 2026
Copilot AI requested a review from JohnAmadis May 29, 2026 07:05
@JohnAmadis JohnAmadis marked this pull request as ready for review May 29, 2026 07:14
@JohnAmadis JohnAmadis merged commit a7ac29e into main May 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release pipeline nie działa

2 participants