Conversation
…at charge parameters are injected to test
chrisiacovella
requested changes
Sep 14, 2024
Member
chrisiacovella
left a comment
chrisiacovella
left a comment
There was a problem hiding this comment.
The coulomb equation is not implemented correctly. it has an extra 1/r and doesn't have the coulomb constant.
Member
Author
|
Thanks for looking through this. I believe this PR was not ready for review; tests are also missing. I will get this prepared until Monday. |
wiederm
commented
Sep 16, 2024
wiederm
commented
Sep 16, 2024
chrisiacovella
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the infrastructure to calculate long-range electrostatics. In the first version, we will calculate the long-range term using a damped coulomb potential (see ref for details).
Todos
Status