Skip to content

Additional scaling factor for force loss (divide by vector length)#239

Merged
wiederm merged 1 commit intomainfrom
dev-loss
Aug 20, 2024
Merged

Additional scaling factor for force loss (divide by vector length)#239
wiederm merged 1 commit intomainfrom
dev-loss

Conversation

@wiederm
Copy link
Copy Markdown
Member

@wiederm wiederm commented Aug 20, 2024

This PR adds a scaling factor to average over the force error calculated per cartesian coordinate. Also, tests are added for the loss function.

Status

  • Ready to go

@wiederm wiederm self-assigned this Aug 20, 2024
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.81%. Comparing base (8c5fa6f) to head (c87a75b).
Report is 3 commits behind head on main.

Additional details and impacted files

@wiederm wiederm merged commit 0afa5b6 into main Aug 20, 2024
@wiederm wiederm deleted the dev-loss branch August 20, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants