Merged
Conversation
…ic_numbers array (single_atom) not series_atom properties. This was causing shifting to be imporperly applied for any system with more than one conformer.
wiederm
approved these changes
Oct 29, 2024
Member
wiederm
left a comment
There was a problem hiding this comment.
Thanks! That should fix the issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Center of mass shifting was failing when a dataset had multiple conformers (accidentally was using indices for the atom_numbers, which are not duplicated between multiple conformers, instead of using the indices that referred to series data). As such, this was working fine for qm9, which was used for testing, but failing for all other datasets PhAlkEthOH.
Key changes
Notable points that this PR has either accomplished or will accomplish.
Associated Issue(s)
Pull Request Checklist