Bug fix: dimers + unique_pairs_only#348
Merged
chrisiacovella merged 5 commits intochoderalab:mainfrom Apr 1, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (81.58%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This fixes a bug where the shape of the underlying tensors in the PairListData was incorrect when evaluating the neighbors of a dimer with unique_pairs_only.
This issue stemmed from squeezing the array for masking; when that mask only had dimension 1, it was squashed. The addition of a reshape(-1) fixes this issue. Tests for the dimer edge case were also added.
This also addresses the issue with calculating the AngularSymmetryFunction for dimers. As discussed in the linked issue, for a dimer, where there are no angles, this tensor is empty. Reshaping the empty tensor was undefined; changing this to use flatten instead works for all cases. This edge case was missed in the ani testing due to the fact the 1000 conformer test say does not feature one of the ~10 dimer systems in the dataset (and thus failure was only observed when training with the full dataset). Additional tests still are required to cover this edge case.
Associated Issue(s)
Pull Request Checklist