Make simulation-backends individual python packages#2
Make simulation-backends individual python packages#2mberz merged 60 commits intoprep_engd_mergefrom
Conversation
namespace in scipy.spatial
- Move fixture definitions to conftest - Move fixture tests to test_fixtures.py
in the interface code
version for edg-acoustics does not support Python 3.14
also added unit tests for this
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 51 out of 52 changed files in this pull request and generated 8 comments.
Comments suppressed due to low confidence (1)
de_method/de_interface/DEinterface.py:29
DEMethod.run_simulationintroduces an optionaljson_file_pathparameter, but the abstract base class definesrun_simulation(self)with no parameters. Keeping consistent method signatures across implementations makes the interface clearer; either remove the parameter and always useself.input_json_path, or update the base class contract.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@SilvinWillemsen: This should be ready for a good old user test now, thanks! 🥳 |
|
Hey @mberz, thanks! When trying to run the CHORAS_BUILD.sh script I'm getting an error (see below). The branches that I test from are: Let me know if there is anything I'm doing wrong! |
1 similar comment
|
Hey @mberz, thanks! When trying to run the CHORAS_BUILD.sh script I'm getting an error (see below). The branches that I test from are: Let me know if there is anything I'm doing wrong! |
|
Can you confirm if you're building a ARM or x86_64 container? |
|
Hi @mberz, I'm simply running the CHORAS_BUILD.sh script that references the docker-compose file. All seems to be set to linux/amd64 |
|
Hey, I could not reproduce the issue you are facing, so I created build actions which build the Docker containers for all methods. As far as I see they are all passing the build. So I have no clue what's causing the issue. |
|
For future reference, the issue I was experiencing was due to poor internet connection. |
Proposed Changes
This pull request refactors the simulation method interfaces into Python packages and introduces minimal tests for the each method.
This simplifies dependency management for execution/testing and allows for simplified specification of package configurations, licenses, etc.
Packaging
pyproject.tomlfile for each package, specifying dependencies, optional dependencies, and entry points for CLI usage (de_interface:main). This replaces the previousrequirements.txtapproach.Dockerfileto install the package using pip and set the working directory, improving build reproducibility and caching.Refactoring and Organization
DEinterface.py,definition.py(with an abstract base class), and CLI entry points (__cli__.py,__main__.py,__init__.py).Testing
conftest.pyCleanup
ci.yml) and the oldrequirements.txt, as these are superseded by the new package and workflows.Code Quality and Style
Method Specific Changes
acousticDE
Note: The DeepONet method is not implemented yet.
Related
closes #1