Conversation
When trview is associated with level files and you open a level in explorer if the path has spaces in then the `CommandLineToArgvW` will split on spaces - we now stick them back together to form the original path. This means flags have to come first but they aren't really used yet anyway. Also fixes an issue in the map renderer where it would try to use imgui before it was ready in some situations. Closes #1192
lahm86
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trview is associated with level files and you open a level in explorer if the path has spaces in then the
CommandLineToArgvWwill split on spaces - we now stick them back together to form the original path.This means flags have to come first but they aren't really used yet anyway.
Also fixes an issue in the map renderer where it would try to use imgui before it was ready in some situations.
Closes #1192