Skip to content

Customise minimap colours in settings window#901

Merged
chreden merged 18 commits intomasterfrom
issue/176
Mar 6, 2022
Merged

Customise minimap colours in settings window#901
chreden merged 18 commits intomasterfrom
issue/176

Conversation

@chreden
Copy link
Copy Markdown
Owner

@chreden chreden commented Mar 3, 2022 •
edited
Loading

  • Add colour pickers in the settings window to select minimap colours
  • Add reset buttons next to pickers to reset to default
  • Improve ImGui testing IDs to no longer require actual ImGui windows
  • Create click_element_with_hover when hovering is required instead of having false, true on the end.

Closes #176

chreden added 13 commits March 2, 2022 18:07
@chreden
Move minimap colour selection to class
31f2e50 
Just returns the default colours at the moment.
Will have overrides at some point.
#176
@chreden
Note the missing colours
5bc76f8 
#176
@chreden
Raise event for map colours changing
8470bca 
Listen to event and pass to map renderer
#176
@chreden
Pass settings to room window
825e1dc 
Room windows have a map renderer too, so pass them the colours
#176
@chreden
Add missing colours
7977951 
#176
@chreden
Add resets and colour loading to settings
03fcdd4 
#176
@chreden
Move minimap setting to minimap
e978583 
Also raise colours on reset
Update tests
#176
@chreden
Try and fix IDs for imgui testing
02d8876 
Make them not actually use a window
@chreden
Update imgui id to not use a window
9770697 
#176
@chreden
Tidy up imguiid a bit
0bb26ce 
#176
@chreden
Store hover id up front
f0a0d36 
#176
@chreden
Clean up changes to tests
3beb54f 
#176
@chreden
Tests for settings window
e955a01 
#176
@chreden chreden changed the title Issue/176 Customize minimap colours in settings window Mar 4, 2022
@chreden chreden self-assigned this Mar 4, 2022
@chreden chreden requested a review from makotocchi March 4, 2022 16:29
@chreden chreden marked this pull request as ready for review March 4, 2022 16:29
@chreden chreden changed the title Customize minimap colours in settings window Customise minimap colours in settings window Mar 4, 2022
@chreden chreden merged commit bc7b3f1 into master Mar 6, 2022
@chreden chreden deleted the issue/176 branch March 6, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@makotocchi makotocchi makotocchi approved these changes

Assignees

@chreden chreden

Labels

quality of life ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Minimap - Colour picker

2 participants

@chreden @makotocchi