Conversation
In the various window managers the `shared_ptr` for the newly created window was being captured in a lambda so that it could be removed from the window collection on an event when it was closed. Unfortunately capturing the `shared_ptr` meant it outlived where it was stored, so there was a crash. Change to capture a `weak_ptr` instead - it should have been this in the first place as the `_closing_windows` field is a `vector` of `weak_ptr`s anyway. Closes #919
chreden
added a commit
that referenced
this pull request
Apr 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the various window managers the
shared_ptrfor the newly created window was being captured in a lambda so that it could be removed from the window collection on an event when it was closed. Unfortunately capturing theshared_ptrmeant it outlived where it was stored, so there was a crash.Change to capture a
weak_ptrinstead - it should have been this in the first place as the_closing_windowsfield is avectorofweak_ptrs anyway.Closes #919