Conversation
If the user entered 0 as the index in the `GoTo` window ImGui would not return true for that - so the `on_selected` event was never raised. Instead we also raise the event in the section that closes the dialog on escape/enter - it is still raised in the `InputInt` check as the +/- arrows trigger that path. Also change `ViewerUI` to pass the currently selected room/item as an initial value when making the `GoTo` window visible. This is a bit nicer than it always being at 0. Closes #968
makotocchi
approved these changes
May 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user entered 0 as the index in the
GoTowindow ImGui would not return true for that - so theon_selectedevent was never raised. Instead we also raise the event in the section that closes the dialog on escape/enter - it is still raised in theInputIntcheck as the +/- arrows trigger that path.Also change
ViewerUIto pass the currently selected room/item as an initial value when making theGoTowindow visible. This is a bit nicer than it always being at 0.Bug reported by @TempleOfHorus
Closes #968