Fix issues with overlap#2
Merged
chris6647 merged 1 commit intochris6647:feature/bottom-navigation-view-controllerfrom Jan 9, 2018
mario:feature/bottom-navigation-view-controller
Merged
Fix issues with overlap#2chris6647 merged 1 commit intochris6647:feature/bottom-navigation-view-controllerfrom mario:feature/bottom-navigation-view-controller
chris6647 merged 1 commit intochris6647:feature/bottom-navigation-view-controllerfrom
mario:feature/bottom-navigation-view-controller
Conversation
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Owner
|
Could you give me some more information as to the issue this fixes? Along with steps to reproduce the issue it fixes. I just see that you move some of the setup into onAttach instead, and the commit message just mentions something with overlap. |
Author
|
Of course. Since onViewBound is invoked only once, there's the following problem:
|
Owner
|
Turns out that we actually had the same issue (just still within a single activity) in our backlog, and this does indeed fix it :) Thanks! |
chris6647
merged commit 2c31011
into
chris6647:feature/bottom-navigation-view-controller
Author
|
Awesome! Glad I was of help! If you'd at any point like to know where your work is used, let me know and I'll point you to it! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mario Danic mario@lovelyhq.com