Add pragma no cover to redis connection retry in conftest#264
Merged
chrisguidry merged 1 commit intomainfrom Dec 23, 2025
Merged
Add pragma no cover to redis connection retry in conftest#264chrisguidry merged 1 commit intomainfrom
chrisguidry merged 1 commit intomainfrom
Conversation
The `except ConnectionError` in `_wait_for_redis` is a timing-dependent branch that's essentially impossible to reliably hit in tests - it fires when Redis hasn't started yet during container spinup. Marking it with `pragma: no cover` to avoid flaky coverage. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
📚 Documentation has been built for this PR! You can download the documentation directly here: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 55
Lines 9018 9016 -2
Branches 450 450
=========================================
- Hits 9018 9016 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
except ConnectionErrorin_wait_for_redisis a timing-dependent branch that's essentially impossible to reliably hit in tests - it fires when Redis hasn't started yet during container spinup. Marking it withpragma: no coverto avoid flaky coverage.🤖 Generated with Claude Code