feat: allow the use of custom search engines #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me. can you maybe add some details to the |
added 2 commits
September 29, 2023 09:49
The current system only allows a hardcoded selection of search engines to be used. With this change the user can use any search engine through the search_engine variable. The downside is that now people can misconfigure the variable which will prevent search handler from working, but I think that's a fair trade off.
chrishrb
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current system only allows a hardcoded selection of search engines to be used.
With this change the user can use any search engine through the search_engine variable.
The downside is that now people can misconfigure the variable which will prevent search handler from working, but I think that's a fair trade off.