Added feature to refresh lock screen on OSX 10.10#20
Merged
chrishunt merged 1 commit intochrishunt:masterfrom Nov 23, 2014
Merged
Added feature to refresh lock screen on OSX 10.10#20chrishunt merged 1 commit intochrishunt:masterfrom
chrishunt merged 1 commit intochrishunt:masterfrom
Conversation
Owner
|
Woohoo! Thank you. Looks great to me. I'm going to follow up with some style stuff in another PR, but I'm happy to merge this. ✨ |
chrishunt
added a commit
that referenced
this pull request
Nov 23, 2014
Added feature to refresh lock screen on OSX 10.10
Contributor
Author
|
You're most welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @chrishunt I had just stumbled upon your podcast (via Smashing Robots) and heard about this little gem which works like a charm.
What's this PR do?
On Mac 10.10 (Yosemite) there is a blurred version of the wallpaper set for the login/lock screen but these were not getting updated through the
desktop set <filename>command. I have added a step that removes this cache file so the next time the lock/login screen are visited thepngwill be regenerated from the new wallpaper.Please feel free to double check but this should not cause any backwards compatibility issues as I check for the cache files existence before removing it.
Where should the reviewer start?
Changes only in ' lib/desktop/osx/osx.rb` and corresponding test file
How should this be manually tested?
Find yourself a yosemite machine
desktop set <something-great>then lock or logout the machine.Screenshots (if appropriate)
Screen in question
![Uploading image.png . . .]()
Questions: