Fix SQL schema for associated launchers #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IN launchers AS l ON sl.launcher_id = l.id
Owner
|
Thanks for you PRs. I will check them out quickly. |
Owner
|
Excellent. Merged |
chrisism
added a commit
that referenced
this pull request
Jan 4, 2025
Merge release/1.5.2 into master Release/1.5.2 (#43) * Added commit for delete (#38) * [hotfix] Clear warning message when rendered file is not available * Update Displayed ROM name after scraping (#42) * add .DS_Store to .gitignore * update scranned rom name if `scan_ignore_scrap_title` setting is unset * Fix SQL schema: launchers (#39) * Fix launcher selection (#40) * fix crash when updating rom data using collection name (missing object) instead of entity_name (#41) * Updated kodi addon checker to .35 * changelog update * SQL fix * Updated incorrect import * Feature/fix standalone (#44) * Added descriptions to add dialog * Make standalone actually launchable * Made standalone launcher queryable * Moved pytest ini * Updated changelog * Updated module * Updated module version reference * Undid launch command change * Fix for not existing entry in addon settings * No errors on not found * When creating dto add missing assetpaths * Added asset path support on ROM level * updated changelogd * new addon command parser * Fix scraper settings * Updated refs and source rendering * Fix in path check * Fix with incorrect type assetpath * Implemented addons methods for script runs --------- Co-authored-by: chrisism <crizizz@gmail.com> Co-authored-by: Alexey Martemyanov <mallexxx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The pull request fixes broken rom/source launcher association as according sql views have wrong join arguments.
FOREIGN KEY (launcher_id)in tables definitions to referenceslauncherstable instead of misspelledlaunchervw_source_launchersandvw_rom_launchersviews toINNER JOIN launchers AS l ON rl.launcher_id = l.idinstead of mistakenly setsl.source_id,rl.rom_id