Skip to content

Feature: 'semver get'#27

Merged
chriskilding merged 5 commits intomasterfrom
feature/get
Apr 7, 2019
Merged

Feature: 'semver get'#27
chriskilding merged 5 commits intomasterfrom
feature/get

Conversation

@chriskilding
Copy link
Copy Markdown
Owner

Fixes #9

@chriskilding chriskilding self-assigned this Mar 25, 2019
@chriskilding
Copy link
Copy Markdown
Owner Author

chriskilding commented Mar 25, 2019

Questions:

  • Should this be called 'get'? Or is another more *nix-like name more appropriate?
  • Should the tests from other 'get-' subcommands be reallocated to this one?
  • Should the other 'get-' subcommands be subsumed into this one as CLI flag arguments?
    • Example: semver get --major <version>
    • Example: semver get --minor <version>
  • Should the 'decrement-' and 'increment-' subcommands be redesigned to take (mandatory) CLI flag arguments? Example: semver increment --major <version> No - because the component indicator for those commands is mandatory, not optional. At least, no need to change them in the initial release.
  • Should it let users pick a custom delimiter character? No - not in version 1.
  • Should it take a custom 'printf'-style C-string (search and replace '%major', '%minor' etc)? No - there is little precedent for printf with app-specific replacement markers in other *nix CLI programs (except maybe for printk in the Linux kernel). This would make it harder to use than standard CLI flag arguments.
  • Should it take a custom awk program (interpolate '$1', '$2' etc) which is then actually passed to awk under the covers? No - this would have to be passed to a bash invocation of awk under the hood.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2019

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #27   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         199    230   +31     
  Branches       20     24    +4     
=====================================
+ Hits          199    230   +31
Impacted Files Coverage Δ
semver 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c4b3a...cd64714. Read the comment docs.

@chriskilding chriskilding marked this pull request as ready for review April 7, 2019 21:37
@chriskilding chriskilding merged commit b582e2e into master Apr 7, 2019
@chriskilding chriskilding deleted the feature/get branch April 7, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant