Skip to content

Fixed nested pdf data merging#487

Open
ExtReMLapin wants to merge 4 commits intochrismattmann:masterfrom
ExtReMLapin:fix_nested_pdf
Open

Fixed nested pdf data merging#487
ExtReMLapin wants to merge 4 commits intochrismattmann:masterfrom
ExtReMLapin:fix_nested_pdf

Conversation

@ExtReMLapin
Copy link
Copy Markdown

Fixes #486

Why am I the first one to meet this issue ???

@chrismattmann
Copy link
Copy Markdown
Owner

Can you add a unit test that demonstrates that this works, @ExtReMLapin ?

@chrismattmann
Copy link
Copy Markdown
Owner

@afuetterer can you take a look?

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 67.544% (-0.009%) from 67.553% — ExtReMLapin:fix_nested_pdf into chrismattmann:master

@afuetterer
Copy link
Copy Markdown
Contributor

Sorry, no.
I don't enjoy the tone of issue and PR description and will not be a part of this interaction.

@ExtReMLapin
Copy link
Copy Markdown
Author

IMO It's better to have E2E tests, but this one should be more than enough.
And i'm not sure about hosting this PDF or making a dummy one generated at runtime.

Anyway the test it there, it's probably better to squash commit commits on merge.

@ExtReMLapin
Copy link
Copy Markdown
Author

ExtReMLapin commented Apr 27, 2026

@afuetterer my point there is It's surprising to see a bug caused by 11 years old code, I would have expected it to be met sooner by anyone else.

Being on the bleeding edge forces us to get bugs fixed everywhere, most of the time on "young" libraries or very actives ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pdf:charsPerPage is broken for nested PDFs

4 participants