feat: guided onboarding Phase 3 (messaging, help text, scripts polish, --yes de-emphasis)#21
Merged
Merged
Conversation
… TDD tests (Phase 0) - New module src/cli/interactive.zig with SelectionItem / MultiSelectResult types - Stub runMultiSelect (all-checked + confirmed for now) - Pure helper getSelectedLabels - Basic unit tests using fixed-buffer I/O pattern (consistent with rest of CLI) - Exposed via src/cli/mod.zig - No behavior change to any command yet Part of approved guided post-install plan (one PR per phase).
…or host integration - Real runMultiSelect implementation (toggle by number, c=confirm, q=cancel) - Works in both TTY (interactive) and non-TTY (safe auto-confirm) environments - Respects caller-provided checked state - Updated tests for new semantics - Foundation for full raw-mode checkbox UI in future refinement This makes the guided onboarding experience actually usable today.
…Phase 1+2 progress) - When run on TTY without --auto, 'orca setup' now offers interactive host selection using the new multi-select - Respects existing --auto path for scripts/CI 100% - Uses the existing doctor report + plugin install infrastructure - Functional line-based experience delivered (raw mode can be added on top) Significant step toward the approved 'one line install → guided value' vision.
…sh and --yes de-emphasis - Update src/cli/help.zig for setup (now describes guided TTY default) and plugin (promotes setup, de-emphasizes --yes for primary path) - De-emphasize --yes throughout plugin doctor fix hints in src/cli/plugin.zig (now leads with 'orca setup or ...') - Update re-enable guidance in disable.zig and help - Update dashboard quick-start example to prefer 'orca setup' - Soften non-interactive error messaging in setup.zig - Update Windows install.ps1 post-install instructions to match sh (simple 'orca setup' + guided note) - Add TDD tests in src/cli/mod.zig that verify new help content (RED->GREEN verified) - Decision: no lightweight shorthands (e.g. orca hermes) added in this phase to keep scope minimal and focused on messaging Refs: approved plan Phase 3, prior phase-1/2 branches, orca-guided-onboarding skill. One PR per phase discipline followed. Non-interactive --auto path untouched. Builds and relevant tests green. Public repo hygiene verified before commit.
…ing (PR #21) - TDD Red→Green: added allocator safety test + errdefer per-field cleanup in interactive.runMultiSelect so error paths during item construction never leak (was leaking owned slice + label/id dups). - Major dedup: replaced ~30 lines of duplicated TTY loop + manual allocation in setup.runGuidedSetup with call to the shared interactive.runMultiSelect + deinitMultiSelectResult. The module is now actually used by the primary guided path. - Ran zig fmt on all touched files (setup.zig and plugin.zig had style drift). - All new safety tests pass cleanly, no new leaks, zig build clean, zig fmt --check clean. - Pre-existing phase38 test failures unrelated to this PR or these fixes. This resolves the highest-severity issues found in the rigorous Zig systems review of the Phase 3 messaging + interactive work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 of the Orca Guided CLI Onboarding & Verbosity Reduction initiative (one PR per phase).
What's in this PR
orca help setupandorca help plugin(and disable) to describe the new guided interactive default on TTY terminals and de-emphasize--yes/--autoas the primary path.--yesin allorca plugin doctorfix hints (now leads withorca setup or orca plugin install ...).install.ps1final messaging to match the improvedinstall.sh(simpleorca setup+ guided note).cli/mod.zigthat assert on the new help content (written first, now passing).Scope decisions
orca hermes) in this phase — kept laser-focused on messaging & DX polish per plan.--auto/--yespaths 100% untouched in behavior and code paths.Verification
zig buildclean.Refs: approved plan (Phase 3), handoff-orca-guided-onboarding.md, orca-guided-onboarding skill, previous Phase 0/1 work on
feat/guided-onboarding-phase-1.Ready for review. Next: Phase 4 (hardening, raw terminal if feasible, docs, final E2E sim).