Skip to content

fix(frontend): model selection validation and inline error banner#232

Open
chriswritescode-dev wants to merge 2 commits into
mainfrom
forge/model-select-fix
Open

fix(frontend): model selection validation and inline error banner#232
chriswritescode-dev wants to merge 2 commits into
mainfrom
forge/model-select-fix

Conversation

@chriswritescode-dev
Copy link
Copy Markdown
Owner

Summary

  • Validate model availability before sending prompts to prevent invalid request errors
  • Replace toast-based send error handling with persistent inline error banners
  • Fix stale model state by properly clearing active model when provider changes
  • Add preflight check in useSendPrompt to block requests to unavailable models
  • Refactor GitErrorBanner into reusable ErrorBanner component

Changes

  • Add model availability preflight check in useOpenCode.ts
  • Create sendErrorStore for per-session error tracking
  • Add ErrorBanner UI component with title, summary, detail, and dismiss
  • Add SessionSendErrorBanner component for session-specific errors
  • Fix validateAndSyncModel to clear stale model selection
  • Replace showToast.error with inline error banners in useSendPrompt
  • Add 29 new tests across 6 test files

Checks

  • pnpm vitest run src/stores/modelStore.test.ts src/stores/sendErrorStore.test.ts src/hooks/useSendPrompt.test.ts src/components/ui/error-banner.test.tsx src/components/session/SessionSendErrorBanner.test.tsx src/pages/tests/SessionDetail.sendError.test.tsx

OpenCode Agent added 2 commits May 22, 2026 21:00
…ect dropdown

When the same model exists under multiple providers, show the provider name
for both entries so users can distinguish them. Detects duplicates by modelID
across all favorites and recents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant