Merged
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
8fbd5fd to
06a463b
Compare
9dd82fe to
00cbffa
Compare
06a463b to
b2ba204
Compare
bd1e289 to
fd2fbbd
Compare
sanketkedia
approved these changes
Mar 26, 2025
HammadB
approved these changes
Mar 27, 2025
a700883 to
cdf9944
Compare
The readme says bucket by 4096 using hex; I was doing dec 5000. This PR changes the bucketing to be groups of 4096 and uses a padded hex for the digits.
024fee9 to
504f581
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readme says bucket by 4096 using hex; I was doing dec 5000.
This PR changes the bucketing to be groups of 4096 and uses a padded hex for the digits.