Skip to content

[CLN] wal3 doc<->code sync#4049

Merged
rescrv merged 3 commits intorescrv/wal3-scrubfrom
rescrv/wal3-cleanup
Mar 27, 2025
Merged

[CLN] wal3 doc<->code sync#4049
rescrv merged 3 commits intorescrv/wal3-scrubfrom
rescrv/wal3-cleanup

Conversation

@rescrv
Copy link
Contributor

@rescrv rescrv commented Mar 21, 2025

The readme says bucket by 4096 using hex; I was doing dec 5000.
This PR changes the bucketing to be groups of 4096 and uses a padded hex for the digits.

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv force-pushed the rescrv/wal3-scrub branch from 8fbd5fd to 06a463b Compare March 23, 2025 22:32
@rescrv rescrv force-pushed the rescrv/wal3-cleanup branch from 9dd82fe to 00cbffa Compare March 23, 2025 22:33
@rescrv rescrv force-pushed the rescrv/wal3-scrub branch from 06a463b to b2ba204 Compare March 24, 2025 17:49
@rescrv rescrv force-pushed the rescrv/wal3-cleanup branch 2 times, most recently from bd1e289 to fd2fbbd Compare March 24, 2025 19:53
@rescrv rescrv requested review from HammadB and sanketkedia March 24, 2025 23:48
@rescrv rescrv force-pushed the rescrv/wal3-scrub branch from a700883 to cdf9944 Compare March 27, 2025 22:12
rescrv added 3 commits March 27, 2025 15:13
The readme says bucket by 4096 using hex; I was doing dec 5000.
This PR changes the bucketing to be groups of 4096 and uses a padded hex for the digits.
@rescrv rescrv force-pushed the rescrv/wal3-cleanup branch from 024fee9 to 504f581 Compare March 27, 2025 22:14
@rescrv rescrv merged commit 86e971f into rescrv/wal3-scrub Mar 27, 2025
95 checks passed
@rescrv rescrv deleted the rescrv/wal3-cleanup branch June 6, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants