[ENH] State machine based property tests for GC.#4057
Merged
rohitcpbot merged 14 commits intomainfrom Mar 25, 2025
Merged
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
rohitcpbot
commented
Mar 21, 2025
| sea-query-binder = { workspace = true, features = ["sqlx-sqlite"] } | ||
| chrono = { workspace = true } | ||
| prost = { workspace = true } | ||
| derivative = "2.2.0" |
Contributor
Author
There was a problem hiding this comment.
derivative allows to skip Debug implementation for storage.
If this does not feel correct, i can remove this and use an alternate approach.
1 task
HammadB
approved these changes
Mar 24, 2025
Properties checked - a) versions after cutoff are deleted b) versions before cutoff are preserved c) versions in version file are ordered d) min versions are retained
Includes changes to TestSysDb. Adding version_file_name to proto.
Removing the Tilt based integration test as a prop test. Removing prop test in the operator. Removing a field that is not needed.
Segment info was not copied properly resulting in prop test failures.
Remove them from various places that were setup for debugging. Converted few to tracing::debug for future debugging.
rohitcpbot
force-pushed
the
rcp/GC-PropTest-Review
branch
from
fefb6a2 to
47a783e
Compare
Inventrohyder
pushed a commit
to Inventrohyder/chroma
that referenced
this pull request
Aug 5, 2025
## Description of changes State machine based property tests for Garbage Collection. Does not depend on the entire cluster to be up using Tilt. Uses sparse index based abstractions to add new versions to the collection. This is a replacement for the prop tests in chroma-core#3883 That PR will be closed in favor of this. *Summarize the changes made by this PR.* - Improvements & Bug fixes - Adds property tests that are not dependent on Tilt. - New functionality - ... ## Test plan *How are these changes tested?* - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
State machine based property tests for Garbage Collection.
Does not depend on the entire cluster to be up using Tilt.
Uses sparse index based abstractions to add new versions
to the collection.
This is a replacement for the prop tests in
#3883
That PR will be closed in favor of this.
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?