Skip to content

Conversation

@rescrv
Copy link
Contributor

@rescrv rescrv commented Apr 4, 2025

This trace says, "Error", but is recoverable. So warn instead.

@rescrv rescrv requested a review from HammadB April 4, 2025 17:30
@github-actions
Copy link

github-actions bot commented Apr 4, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

This trace says, "Error", but is recoverable.  So warn instead.
@rescrv rescrv force-pushed the rescrv/downgrade-error-to-warn branch from 2b59484 to a8497d0 Compare May 14, 2025 23:03
@propel-code-bot
Copy link
Contributor

Changes an error-level trace to a warning-level trace for a recoverable error when purging dirty records for collections. Added documentation explaining that this condition should be known but doesn't require action beyond skipping the collection.

This summary was automatically generated by @propel-code-bot

@rescrv rescrv merged commit c9c898e into main May 22, 2025
70 checks passed
@rescrv rescrv deleted the rescrv/downgrade-error-to-warn branch May 22, 2025 18:18
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
)

This trace says, "Error", but is recoverable.  So warn instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants