Skip to content

Conversation

@pmeier
Copy link

@pmeier pmeier commented Apr 7, 2025

Description of changes

Fixes #4190

@github-actions
Copy link

github-actions bot commented Apr 7, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jairad26
Copy link
Contributor

jairad26 commented Apr 7, 2025

thank you for the PR @pmeier, could you modify the PR title and push an empty commit to retrigger the PR title check?

@pmeier pmeier changed the title retrieve model fields from type instead of instance [ENH] retrieve pydantic model fields from type instead of instance Apr 7, 2025
@pmeier
Copy link
Author

pmeier commented Apr 7, 2025

Done @jairad26

@pmeier
Copy link
Author

pmeier commented Apr 23, 2025

Maybe superseded by #4339.

@pmeier pmeier closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Collection.get_model_fields emits warnings for Pydantic 2.11

2 participants