Skip to content

[1.4] Fix missing destroyed #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GrahamCampbell merged 2 commits into from
Jan 25, 2022
Merged

[1.4] Fix missing destroyed #338

GrahamCampbell merged 2 commits into from
Jan 25, 2022

Conversation

@momala454
Copy link
Contributor

@momala454 momala454 commented Jan 25, 2022

Without it, it can cause

Call to a member function sendMessage() on null in .../Communication/Session.php:68

because

$this->getConnection()->sendMessage

when it's already destroyed, destroyed is never set and then
getConnection() return null

GrahamCampbell
GrahamCampbell requested changes Jan 25, 2022
View reviewed changes
@GrahamCampbell GrahamCampbell merged commit b0f5565 into chrome-php:1.4 Jan 25, 2022
@GrahamCampbell GrahamCampbell changed the title Fix missing destroyed [1.4] Fix missing destroyed Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@momala454 @GrahamCampbell