Conversation
added 2 commits
July 12, 2014 22:57
usmanm
changed the title
usmanm
changed the title
Contributor
|
this lgtm, but the If not, at least change |
Contributor
There was a problem hiding this comment.
docstring on what reverse does. Also consider changing the name as per comment above :)
Member
Author
|
I don't want to leak kronos level stuff into TimeUUID. I'll change it to descending. |
Contributor
There was a problem hiding this comment.
"optional, False by default, which sorts in ascending order"
Contributor
|
change comment and them lgtm---land when ready |
usmanm
added a commit
that referenced
this pull request
Jul 14, 2014
Add descending sort ability, __str__ and bump version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional keyword argument
reversetoTimeUUIDs constructor.Falseby default, but if set toTrueit will reverse the comparison operation.