Conversation
Member
Author
|
TODO: Ch341a and Flipper Zero pages are missing this aswell |
ninelore
requested review from
WeirdTreeThing,
ellyq,
ethanaobrien,
meghan06 and
mine-man3000
ethanaobrien
approved these changes
Feb 1, 2024
Member
|
Should include hwid preservation too |
ethanaobrien
suggested changes
Feb 1, 2024
ethanaobrien
approved these changes
Feb 2, 2024
WeirdTreeThing
requested changes
Feb 2, 2024
Member
WeirdTreeThing
left a comment
WeirdTreeThing
left a comment
There was a problem hiding this comment.
as I said before, this should also mention persisting hwid
Member
Author
isnt that included in the (term) vital product data? |
Member
|
No. HWID is part of the GBB, not RO_VPD. |
Member
|
@ninelore VPD Preservation is not possible with FZ (Flipper Zero) from my testing. HWID preservation is also untested. https://docs.chrultrabook.com/docs/unbricking/unbrick-flipper.html#preparations |
Member
Author
|
@WeirdTreeThing I consider HWID preservation out of scope of this PR since is has not been covered at all by the docs yet. |
Member
|
It's two commands... |
Member
Author
|
will redo this from scratch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131