Remove Cell::shared1 and Cell::shared2, use tempValue1/tempValue2 instead#561
Merged
chrxh merged 2 commits intofeatures/CreatureCheckfrom Mar 19, 2026
Merged
Conversation
…tempValue2.as_float2 instead Co-authored-by: chrxh <73127001+chrxh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove Cell::shared1 and Cell::shared2 for tempValue1 and tempValue2
Remove Cell::shared1 and Cell::shared2, use tempValue1/tempValue2 instead
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate
shared1/shared2fields into the existingTempValueunion fields. These serve the same role (per-object scratch storage across kernel phases) and never overlap temporally — physics uses them for force accumulation, then cell state transitions reuse the same memory via theas_uint32_floatview.float2 shared1andfloat2 shared2fromObjectstruct inEntities.cuhObjectProcessor.cuh:shared1→tempValue1.as_float2,shared2→tempValue2.as_float2shared1 = {0,0}init (already covered bytempValue1.as_uint64 = 0)📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.