Fix getHexagonRequiredNodeId3 for high ring values#587
Merged
chrxh merged 1 commit intofeatures/ConstructionSequencesfrom Apr 8, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/chrxh/alien/sessions/736fd9ad-aed1-401d-acd9-077f206c31f8 Co-authored-by: chrxh <73127001+chrxh@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
chrxh
April 8, 2026 19:43
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getHexagonRequiredNodeId3produced wrongrequiredNodeId3values for large hexagons (highk), causing broken topology in rings beyond ~2.Three formula/logic errors in even-
kbranches:3k²-5k-1-((pos-1)/2)→3k²-5k-pospos == 2; now handles all evenpos ≥ 2with3k²-6k+2-(pos-2)k == 2special case; fixed formula from3k²-6k-pos→3k²-7k+4-posVerified with
generateHexagon_61cells_withSeparation(5-ring, 61-cell hexagon).