Unify hexagon construction data: merge angle + nodeId methods into single flow#590
Merged
chrxh merged 4 commits intofeatures/ConstructionSequencesfrom Apr 9, 2026
Conversation
Replace three separate getHexagonRequiredNodeId1/2/3 methods with a single unified getHexagonRequiredNodeIds method implementing the correct algorithm. Two key fixes from the original pseudocode: 1. All n-relative references use n-2/n-3 instead of n-1/n-2 2. C2 segment formulas use D+5s-2 based calculations instead of Dp-based Agent-Logs-Url: https://github.com/chrxh/alien/sessions/b719d3ee-28a1-4698-8bed-6fa47d8a5ca2 Co-authored-by: chrxh <73127001+chrxh@users.noreply.github.com>
…xagonConstructionData method Merge the two separate hexagon helper methods into a single getHexagonConstructionData(int n) that returns a complete ShapeGeneratorResult with both angle and required node IDs. Uses a shared base table for n<=21 containing both angle and node ID data, eliminating the separate lookup tables. Agent-Logs-Url: https://github.com/chrxh/alien/sessions/26b8ddd9-67b1-46f8-a642-d7f54aaeba32 Co-authored-by: chrxh <73127001+chrxh@users.noreply.github.com>
…rHexagon Merge the separate helper method into the single hexagon construction method. Ring decomposition (angle) and shell decomposition (node IDs) now flow together in one method without separate scoped blocks. Agent-Logs-Url: https://github.com/chrxh/alien/sessions/e3cb635f-3518-449e-92cb-7503c19f6df4 Co-authored-by: chrxh <73127001+chrxh@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
chrxh
April 9, 2026 14:55
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getHexagonAngleandgetHexagonRequiredNodeIdswere separate methods with independent decomposition schemes (ring-based for angles, shell-based for node IDs) despite always being called together for the same node index. This made the hexagon construction sequence harder to follow and maintain.Changes
BaseEntryarray with angle + all three node IDs, replacing two separate lookup tablesgenerateNextConstructionDataForHexagon: eliminated the intermediategetHexagonConstructionDatahelper — one method now handles the full hexagon construction sequencegetHexagonAngle,getHexagonRequiredNodeIds, andgetHexagonConstructionDatafrom the class