Skip to content

client thread fixes#371

Merged
chsami merged 16 commits intochsami:developmentfrom
JThomasDevs:vale-totems-fix
Apr 8, 2026
Merged

client thread fixes#371
chsami merged 16 commits intochsami:developmentfrom
JThomasDevs:vale-totems-fix

Conversation

@JThomasDevs
Copy link
Copy Markdown
Contributor

No description provided.

chsami and others added 16 commits March 10, 2026 12:50
fix(AIOMagicPlugin): Bump version to 1.2.3 and add support for Stun a…
…prevent weird bank withdrawal shenanigans (tried withdrawing yew logs)
feat/new-planks + profit calculation fix/update + Lazy Mode
* feat(sailing): fix alch loop, add casket opening and inventory order options

* feat(sailing): fix alch loop, add casket opening and inventory order options

Co-authored-by: stonksCode <99895926+stonksCode@users.noreply.github.com>
fix(TitheFarmingPlugin): Bump version to 1.1.4 and update game object…
fix(TitheFarmingPlugin): Bump version to 1.1.5 and update game object…
* fix: karambwan fairy ring return

Made-with: Cursor

* plugin now clicks on fairy ring to get back to karams

* commit
@chsami chsami changed the base branch from main to development April 8, 2026 05:44
@chsami chsami merged commit f1ed72b into chsami:development Apr 8, 2026
chsami added a commit that referenced this pull request Apr 8, 2026
* fix(aiomagic): Fix stun and added queryable NPC targeting (#365)

* Reduce code smell, implement sawmill vouchers and Lazy Mode

* Change profit calculation to be more accurate, extended Logs enum to prevent weird bank withdrawal shenanigans (tried withdrawing yew logs)

* undo main runner change

* re-add microbot.java. whoops.

* Karam fix (#351)

* fix: karambwan fairy ring return

Made-with: Cursor

* plugin now clicks on fairy ring to get back to karams

* commit

* fix(aiomagic): bring back stable 1.2.6 flow with queryable NPC targeting

•restore missing STUN lifecycle wiring so the mode starts and shuts down correctly
•replace hardcoded StunTeleAlch target/teleport with user-configured NPC + teleport
•move stun/splash NPC lookup to Queryable NPC cache for reliable targeting
•harden stun cast sequence: select spell, confirm selection, then click target NPC

•Plugin version updated 1.2.6

---------

Co-authored-by: chsami <sami.chkhachkhi@gmail.com>
Co-authored-by: Jonathan Thomas <95548936+JThomasDevs@users.noreply.github.com>
Co-authored-by: stonksCode <99895926+stonksCode@users.noreply.github.com>

* Autopray changes and additions (#366)

* Reduce code smell, implement sawmill vouchers and Lazy Mode

* Change profit calculation to be more accurate, extended Logs enum to prevent weird bank withdrawal shenanigans (tried withdrawing yew logs)

* undo main runner change

* re-add microbot.java. whoops.

* Karam fix (#351)

* fix: karambwan fairy ring return

Made-with: Cursor

* plugin now clicks on fairy ring to get back to karams

* commit

* LMS Mode -  antiban, antiban config

Made-with: Cursor

# Conflicts:
#	src/main/java/net/runelite/client/plugins/microbot/qualityoflife/scripts/AutoPrayer.java

* laxed antiban regarding fast weapon switches

* - Added offensive prayers to autoprayer
- Moved autoeat to the client thread
- Throttled autoeating in PvP as to not block prayer switching when trying to spam eat
- Fully fleshed out remaining LMS weapons in WeaponID enum
- changed LMS dd to be classified as melee weapon

Made-with: Cursor

# Conflicts:
#	src/main/java/net/runelite/client/plugins/microbot/qualityoflife/QoLPlugin.java

---------

Co-authored-by: chsami <sami.chkhachkhi@gmail.com>
Co-authored-by: stonksCode <99895926+stonksCode@users.noreply.github.com>

* docs: add Agent Server and Microbot CLI documentation

* fix(AIOFighterPlugin): bump version to 2.0.13 and refactor configuration methods

* client thread fixes (#371)

* Reduce code smell, implement sawmill vouchers and Lazy Mode

* Change profit calculation to be more accurate, extended Logs enum to prevent weird bank withdrawal shenanigans (tried withdrawing yew logs)

* undo main runner change

* re-add microbot.java. whoops.

* Karam fix (#351)

* fix: karambwan fairy ring return

Made-with: Cursor

* plugin now clicks on fairy ring to get back to karams

* commit

* client thread fixes

---------

Co-authored-by: chsami <sami.chkhachkhi@gmail.com>
Co-authored-by: stonksCode <99895926+stonksCode@users.noreply.github.com>

* fix(AIOFighterPlugin): bump version to 2.0.14 and improve player location checks

* fix(AIOFighterPlugin): bump version to 2.1.0 and refactor NPC interaction logic

* fix(AIOFighterPlugin): bump version to 2.1.3 and migrate prayer/slayer/banking/flicker scripts to Queryable API

Continues the AIOFighter Queryable API migration started in 2.1.0:

- PrayerScript / SlayerScript / FlickerScript now inject Rs2NpcCache and
  use rs2NpcCache.query() chains instead of legacy Rs2Npc.* lookups.
- BankerScript injects Rs2TileObjectCache for the Pool of Refreshment
  lookup, replacing Rs2GameObject.get()/interact(). The .nearest(20) bound
  preserves the legacy 51-tile walk-to guard's intent (the new model's
  click() does not walk-to-object).
- Monster.npc swapped to api.npc.models.Rs2NpcModel; AIOFighterOverlay
  is unchanged because both legacy and new models implement Actor.
- Logout-race null guards added to PrayerScript and FlickerScript to
  mirror legacy Rs2Npc.getNpcsForPlayer's empty-stream behavior.
- SlayerScript predicate collapses two getName() calls (each is a
  client-thread invoke) into a single fetch.
- Migrated scripts converted to @Inject in AIOFighterPlugin so Guice
  satisfies their cache fields.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(AIOFighterPlugin): bump version to 2.1.4 and switch Queryable cache access from @Inject to Microbot static accessors

The 2.1.0/2.1.3 @Inject Rs2NpcCache / Rs2TileObjectCache fields and the
@Inject script wiring in AIOFighterPlugin caused Guice's createChildInjector
to throw inside MicrobotPluginManager.instantiate. The Hub plugin loader
silently catches that exception (MicrobotPluginManager.java:564-568): it
logs "Incompatible plugin found", deletes the plugin's JAR from
~/.runelite/microbot-plugins, and returns the partially-constructed plugin
with all @Inject fields still null. The plugin then sat in the UI list and
NPE'd in startUp() at line 150 (config null) when started.

Fix: revert the @Inject script wiring back to `new XxxScript()` and switch
every cache access from injected field to the upstream static accessor
(Microbot.getRs2NpcCache() / Microbot.getRs2TileObjectCache()). The static
fields in Microbot.java are populated via requestStaticInjection in
RuneLiteModule, which is the same pattern Rs2BoatModel uses upstream. This
keeps all the Queryable API call sites identical while bypassing Guice's
plugin-classloader child-injector binding-resolution problem entirely.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(HueyPrayerPlugin): update version to 1.0.1 and enhance plugin descriptor with default settings

* Add Use Cargo Hold to salvaging script and debug thoroughly (#368)

* Reduce code smell, implement sawmill vouchers and Lazy Mode

* Change profit calculation to be more accurate, extended Logs enum to prevent weird bank withdrawal shenanigans (tried withdrawing yew logs)

* undo main runner change

* re-add microbot.java. whoops.

* Karam fix (#351)

* fix: karambwan fairy ring return

Made-with: Cursor

* plugin now clicks on fairy ring to get back to karams

* commit

* Add Use Cargo Hold to salvaging script and debug thoroughly

* various fixes and changed hold capacity counting to use widget information as opposed to walking the item graph

* small fixes

* Boat facilities detection fixes, comment changes

---------

Co-authored-by: chsami <sami.chkhachkhi@gmail.com>
Co-authored-by: stonksCode <99895926+stonksCode@users.noreply.github.com>

* fix(TitheFarmingPlugin): bump version to 1.1.12 and refactor game object interactions to use Rs2TileObjectModel

* mahogany homes client thread fixes (#372)

---------

Co-authored-by: irkedMATT <59846844+irkedMATT@users.noreply.github.com>
Co-authored-by: Jonathan Thomas <95548936+JThomasDevs@users.noreply.github.com>
Co-authored-by: stonksCode <99895926+stonksCode@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants