Skip to content

fix(Fletching): match "Logs" item name when using LOG material#396

Merged
chsami merged 1 commit intochsami:developmentfrom
mdp18:debug/fletching-bank
Apr 16, 2026
Merged

fix(Fletching): match "Logs" item name when using LOG material#396
chsami merged 1 commit intochsami:developmentfrom
mdp18:debug/fletching-bank

Conversation

@mdp18
Copy link
Copy Markdown
Contributor

@mdp18 mdp18 commented Apr 16, 2026

Summary

  • Fixes a bug where the Fletching plugin could not find regular Logs in the bank
  • Root cause: secondary item name was constructed as `material.getName() + " logs"`, producing `"Log logs"` for `LOG` material, which doesn't match the actual OSRS item name `"Logs"`
  • Added `FletchingMaterial.getLogItemName()` that special-cases `LOG` → `"Logs"` and returns `" logs"` for all other materials
  • Updated all three call sites in `FletchingScript` (progressive, manual, and banking paths)
  • Bumped plugin version to 1.6.4

Test plan

  • Start plugin with material=LOG and a stack of regular Logs in the bank, verify it withdraws them successfully
  • Verify other materials (Oak, Willow, Maple, Yew, Magic, Redwood) still work correctly
  • Verify progressive mode correctly picks up plain Logs when level < 15

The bank lookup constructed the secondary item name as
`material.getName() + " logs"`, producing "Log logs" for LOG material
which doesn't match the actual OSRS item name "Logs". Plain logs
therefore were never found in the bank and the script shut down with
"logs not found". Added FletchingMaterial.getLogItemName() that returns
"Logs" for LOG and "<name> logs" for everything else, and routed all
three call sites through it.
@chsami chsami merged commit b262de1 into chsami:development Apr 16, 2026
1 check passed
chsami added a commit that referenced this pull request Apr 16, 2026
* fix(Fletching): match "Logs" item name when using LOG material (#396)

The bank lookup constructed the secondary item name as
`material.getName() + " logs"`, producing "Log logs" for LOG material
which doesn't match the actual OSRS item name "Logs". Plain logs
therefore were never found in the bank and the script shut down with
"logs not found". Added FletchingMaterial.getLogItemName() that returns
"Logs" for LOG and "<name> logs" for everything else, and routed all
three call sites through it.

Co-authored-by: dev <dev@riskless.id>

* feat(LeaguesToolkit): add Leagues utility plugin with anti-AFK (#395)

New standalone plugin for Leagues quality-of-life utilities. First
feature is anti-AFK which presses a configurable input (random arrow
key, backspace, or camera rotation) whenever the client's idle ticks
approach the idle-timeout threshold — prevents logout during long
auto-banking skilling sessions (e.g. mining with Endless Harvest relic).

Configurable trigger buffer window (randomized min/max ticks before
threshold) and input method.

Adds [DV] prefix to PluginConstants.

Co-authored-by: dev <dev@riskless.id>
Co-authored-by: chsami <sami.chkhachkhi@gmail.com>

---------

Co-authored-by: Max <max@riskless.id>
Co-authored-by: dev <dev@riskless.id>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants