fix(auto-smelting): rewrite bail-on-transient-state checks (#433)#434
Merged
Conversation
The script popped "smithing level isn't high enough" / "Could not find item in bank" mid-run and shut down on transient state. Rewrites the condition checks so the loop self-heals instead of bailing on a single bad read. - Use getRealSkillLevel for the smithing gate (was getBoostedSkillLevel, which drains and reads 0 transiently); early-return on a 0 read. - Replace Microbot.showMessage + shutdown in the bank checks with Microbot.log + retry per PLUGIN_DEBUGGING_NOTES.md §6. - Wait for the deposit to settle before withdrawing so Rs2Bank's full-inventory guard doesn't silently skip the cycle-2 withdraw. - Fix duplicate isWearing(ICE_GLOVES) check that masked the regular-gloves branch. - Replace slow per-object ClientThread furnace lookup with withNameContains + nearestOnClientThread. - Catch printing ex.getMessage() -> Microbot.logStackTrace. - Scheduler tick 100ms -> 600ms (game-tick floor). Bumps version 1.0.3 -> 1.0.4. Co-authored-by: runsonmypc <runsonmypc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script popped "smithing level isn't high enough" / "Could not find item in bank" mid-run and shut down on transient state. Rewrites the condition checks so the loop self-heals instead of bailing on a single bad read.
Bumps version 1.0.3 -> 1.0.4.