Merged
Conversation
… of leveraging setters in the Microbot Plugin
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Microbot plugin system by removing setter methods and consolidating configuration and panel management into the MicrobotPlugin class while eliminating the now-unused MicrobotConfigPlugin. Key changes include updating access modifiers across UI classes, modifying method visibilities in plugin panels, and refactoring dependency injection usage in MicrobotPlugin.
Reviewed Changes
Copilot reviewed 25 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| runelite-client/src/main/java/net/runelite/client/plugins/microbot/ui/MicrobotTopLevelConfigPanel.java | Changed class access from package-private to public. |
| runelite-client/src/main/java/net/runelite/client/plugins/microbot/ui/MicrobotPluginListPanel.java | Updated visibility of methods to public to support external access. |
| runelite-client/src/main/java/net/runelite/client/plugins/microbot/ui/MicrobotPluginConfigurationDescriptor.java | Made the class and constructor public. |
| Multiple plugin files (e.g., TitheFarmingPlugin, TannerPlugin, WinePlugin, etc.) | Removed setter method calls in favor of dependency injection. |
| runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotPlugin.java | Refactored plugin startup logic with dependency injection and updated menu handling logic. |
| runelite-client/src/main/java/net/runelite/client/plugins/microbot/GeoffPlugins/lunarplankmake/LunarPlankMakePlugin.java and Construction2Plugin.java | Removed redundant setter call(s) in line with the DI refactor. |
| runelite-client/src/main/java/net/runelite/client/RuneLiteModule.java | Updated static injection to include Microbot. |
runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotPlugin.java
Show resolved
Hide resolved
runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotPlugin.java
Outdated
Show resolved
Hide resolved
runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotPlugin.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this refactor is to remove the setter methods within the Microbot class & only rely on dependency injection for instances of runelite utilities.
Doing this, I have also removed the MicrobotConfigPlugin & moved the panel creation into the MicrobotPlugin - this is the panel that is used to display only microbot plugins.