Skip to content

2.0.17#1549

Merged
chsami merged 9 commits intomainfrom
development
Oct 5, 2025
Merged

2.0.17#1549
chsami merged 9 commits intomainfrom
development

Conversation

@chsami
Copy link
Owner

@chsami chsami commented Oct 5, 2025

Rs2keyboard enter fix: When a script used Rs2Keyboard.enter() it would auto relog for jagex account when being logged out.
Rs2RunePouch fix

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 5, 2025

Walkthrough

  • Bumped Maven property microbot.version from 2.0.16.1 to 2.0.17 in runelite-client/pom.xml.
  • Rs2RunePouch: expanded loadout widget ID set; reworked loadout interaction to locate the parent/child "Load" widget, compute bounds, and invoke via NewMenuEntry with Rs2UiHelper, adding validations and warnings.
  • Rs2Keyboard: class made final; several helper methods made private; refactored internal canvas focus and event posting flow without changing public method surface.
  • Rs2Walker: removed @deprecated from isInArea(WorldPoint, int) with no logic change.

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive The title consists solely of a version number and does not clearly summarize the primary changes or intent of the pull request, making it too generic for teammates reviewing history. Please provide a more descriptive title that highlights the main changes, for example “Bump microbot to 2.0.17 and fix Rs2Keyboard.enter and Rs2RunePouch behavior.”
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed The description clearly relates to the changes by explaining the Rs2Keyboard.enter fix and the Rs2RunePouch fix, so it is on-topic and passes the lenient criteria.
Docstring Coverage ✅ Passed Docstring coverage is 92.31% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b53558 and f3b267b.

⛔ Files ignored due to path filters (1)
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/teleportation_portals.tsv is excluded by !**/*.tsv
📒 Files selected for processing (4)
  • runelite-client/pom.xml (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/inventory/Rs2RunePouch.java (4 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/keyboard/Rs2Keyboard.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java (0 hunks)
💤 Files with no reviewable changes (1)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java
🧰 Additional context used
🧬 Code graph analysis (1)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/inventory/Rs2RunePouch.java (1)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/menu/NewMenuEntry.java (1)
  • NewMenuEntry (11-317)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami merged commit 2687188 into main Oct 5, 2025
3 checks passed
This was referenced Oct 30, 2025
This was referenced Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants