Skip to content

chore(pom): update microbot version to 2.0.31 + fix bankpin and profi…#1578

Merged
chsami merged 1 commit intomainfrom
development
Oct 20, 2025
Merged

chore(pom): update microbot version to 2.0.31 + fix bankpin and profi…#1578
chsami merged 1 commit intomainfrom
development

Conversation

@chsami
Copy link
Owner

@chsami chsami commented Oct 20, 2025

…le updating

@chsami chsami merged commit 7d0eefa into main Oct 20, 2025
0 of 2 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Version bump to microbot.version 2.0.31. Refactors profile activation logic by removing auto-activation from ProfileManager.Lock constructor and eliminating the public static activeProfile field from Login class. LoginManager.activeProfile transitions to setter-only access via @Setter annotation, with a new getActiveProfile() method providing controlled profile retrieval that includes ProfileManager locking. LoginManager.lastLogoutTimestamp field is removed.

Possibly related PRs

  • 2.0.29 #1576: Continues the login/profile migration by removing Login.activeProfile and consolidating profile access through LoginManager.getActiveProfile() with adjusted ProfileManager profile activation behavior.

Note: LoginManager.activeProfile has asymmetric access patterns—the field allows direct setting via generated @Setter, but reading occurs exclusively through getActiveProfile(), which includes additional locking and profile-selection logic. This creates different code paths for write versus read operations on the same logical state.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a4e7194 and 17243cd.

📒 Files selected for processing (4)
  • runelite-client/pom.xml (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/config/ProfileManager.java (0 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/security/Login.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/security/LoginManager.java (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami changed the title chore(pom): update microbot version to 2.0.30 + fix bankpin and profi… chore(pom): update microbot version to 2.0.31 + fix bankpin and profi… Oct 20, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant