Skip to content

2.1.33#1718

Merged
chsami merged 8 commits into
mainfrom
development
Mar 30, 2026
Merged

2.1.33#1718
chsami merged 8 commits into
mainfrom
development

Conversation

@chsami

@chsami chsami commented Mar 30, 2026

Copy link
Copy Markdown
Owner

Bunch of bugfixes

chsami and others added 8 commits March 28, 2026 16:25
@chsami
refactor(reflection): optimize ground item action retrieval with caching
6f81376
@BluBambu @claude
fix(blocking-events): re-queue event on failed CAS in shouldBlockAndP…
f1fd064 
…rocess

When compareAndSet(false, true) fails because another thread started
processing, the already-polled event was silently dropped. Now it is
re-queued so it can be picked up on the next cycle.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@BluBambu @claude
fix(boat-cache): use addition instead of multiplication for cache TTL
a5f2b7b 
lastCheckedOnBoat * 2 produced wildly incorrect cache expiry times.
For example, at tick 500 the cache would persist until tick 1000
(500 extra ticks) instead of the intended 2 ticks. Changed to
lastCheckedOnBoat + 2 to correctly expire after 2 game ticks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@afss0
fix:: update Rs2GrandExchange's isOfferScreenOpen
de53fe1
@chsami
Merge pull request #1716 from afss0/isOfferScreenOpen-fix
5805db9 
fix: Update GE offer screen widget id for Rs2GrandExchange.isOfferScreenOpen()
@chsami
Merge pull request #1710 from BluBambu/fix/blocking-event-race-condition
d1da034 
fix(blocking-events): re-queue event on failed CAS in shouldBlockAndProcess
@chsami
chore(gradle): update build and microbot versions
645086a
@chsami
Merge pull request #1712 from BluBambu/fix/boat-cache-invalidation
6478fc9 
fix(boat-cache): use addition instead of multiplication for cache TTL
@chsami chsami merged commit c62b783 into main Mar 30, 2026
2 of 3 checks passed
@coderabbitai

coderabbitai Bot commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 14863007-ce05-4a1f-84a9-e0edc7db7e78

📥 Commits

Reviewing files that changed from the base of the PR and between dac20bf and 6478fc9.

📒 Files selected for processing (6)
  • gradle.properties
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/BlockingEventManager.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/api/boat/Rs2BoatCache.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/grandexchange/Rs2GrandExchange.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/reflection/Rs2Reflection.java
  • runelite-client/src/test/java/net/runelite/client/plugins/microbot/util/reflection/Rs2ReflectionGroundItemActionsIntegrationTest.java

Walkthrough

This pull request contains version bumps and several targeted fixes across the Microbot plugin. The build version increments to 1.12.22.1 and the Microbot library version to 2.1.33. Code changes include a fix to prevent event loss in BlockingEventManager when concurrent processing is detected, an adjustment to boat cache staleness logic, a correction to the Grand Exchange offer screen widget detection, a comprehensive refactoring of the reflection-based ground item action extraction mechanism with improved caching and error handling, and an addition of integration tests to validate the ground item action discovery logic.

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced Jun 24, 2026
Merged
Closed
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chsami @BluBambu @afss0