chore(shortestpath): remove MoA audit temp debug plugin#1752
chore(shortestpath): remove MoA audit temp debug plugin#1752runsonmypc wants to merge 2 commits intochsami:developmentfrom
Conversation
MoaAuditPlugin and the runMoaAudit()/closeMoaWidgetIfOpen() helpers in Rs2Walker were intended as a temporary offline landing-coord audit tool (self-labelled [TEMP] "Delete when done") and were supposed to be held on a separate debug branch, not merged. They slipped into upstream with PR chsami#1750 because the amend that removed them locally was never pushed before the PR was merged. Scope: delete-only. No functional changes to MoA handling — handleSeasonalTransport, lockedMoaRegions, and blacklistedMoaDestinations are untouched.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 2 minutes and 21 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removing the MoA audit methods shifted lambda indices in Rs2Walker.java, invalidating exact-index baseline entries like lambda$handleTransports$47. Regenerate to match current indices.
|
Superseded by #1751, which now bundles the audit removal to avoid a baseline-regen conflict if these two PRs merged separately. |
1 participant
Summary
Removes the
MoaAuditPluginand therunMoaAudit()/closeMoaWidgetIfOpen()helpers inRs2Walker.These were an offline landing-coord audit tool — the plugin file itself is self-labelled
[TEMP]and comments say "Delete when done". They were intended to live on a separate debug branch and never be merged. They slipped into upstream via PR #1750 because the local amend that removed them was never pushed before that PR was merged. Apologies for the noise.Scope
runelite-client/src/main/java/net/runelite/client/plugins/microbot/moaaudit/MoaAuditPlugin.java— deletedRs2Walker.runMoaAudit()— deleted (~80 lines)Rs2Walker.closeMoaWidgetIfOpen()— deletedNot in scope
No functional changes to MoA handling.
handleSeasonalTransport,lockedMoaRegions,blacklistedMoaDestinationsare untouched.Test plan
./gradlew :client:compileJava— clean build (no refs to the removed symbols).walkTo/nearest bankflow.