Skip to content

2.5.8#1767

Merged
chsami merged 3 commits intomainfrom
development
May 10, 2026
Merged

2.5.8#1767
chsami merged 3 commits intomainfrom
development

Conversation

@chsami
Copy link
Copy Markdown
Owner

@chsami chsami commented May 10, 2026

No description provided.

@chsami chsami merged commit a3a77fc into main May 10, 2026
2 of 3 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 10, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 111fd903-b4f5-4052-b61e-eb7f312b9c94

📥 Commits

Reviewing files that changed from the base of the PR and between 30c1a22 and 828aecb.

⛔ Files ignored due to path filters (2)
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/blocked_edges.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/teleportation_spells.tsv is excluded by !**/*.tsv
📒 Files selected for processing (19)
  • .gitignore
  • docs/F2P_WEBWALKER_HARNESS.md
  • docs/entity-guides/movement.md
  • gradle.properties
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/agentserver/handler/WalkHandler.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/shortestpath/ShortestPathPlugin.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/shortestpath/pathfinder/CollisionMap.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/shortestpath/pathfinder/PathSmoother.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/shortestpath/pathfinder/Pathfinder.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/shortestpath/pathfinder/PathfinderConfig.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/testing/webwalker/F2PWebWalkerHarnessPlugin.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/testing/webwalker/F2PWebWalkerRoute.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/testing/webwalker/GeLumbridgeTeleportHarnessPlugin.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/Global.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java
  • runelite-client/src/test/java/net/runelite/client/plugins/microbot/shortestpath/ShortestPathCoreTest.java
  • runelite-client/src/test/java/net/runelite/client/plugins/microbot/util/walker/Rs2WalkerUnitTest.java
  • runelite-client/src/test/resources/threadsafety/client-thread-guardrail-baseline.txt
  • scripts/run-ge-lumbridge-teleport-harness.sh

Walkthrough

This PR enhances the pathfinding and walking infrastructure by introducing blocked-transport-edge tracking to prevent routing through unavailable agility/grapple shortcuts, refactoring walker transport handling with centralized finalization and path recalculation, adding thread-interruption safety to sleep/polling helpers, and expanding webwalker testing harnesses. Changes span PathfinderConfig (blocked-edges data model and loading), CollisionMap/PathSmoother/Pathfinder (integration), Rs2Walker (transport finalization and routing improvements), Global (interruption-aware polling), WalkHandler/ShortestPathPlugin (integration), F2PWebWalkerRoute/F2PWebWalkerHarnessPlugin (route-execution enhancements), a new GeLumbridgeTeleportHarnessPlugin stress test, and comprehensive test coverage with regression tests for Varrock Sewers pathing edge cases.

Possibly related PRs

  • chsami/Microbot#1765: Modifies same webwalker/shortest-path/walker codepaths including WalkHandler, Rs2Walker, CollisionMap, and PathfinderConfig.
  • chsami/Microbot#1750: Modifies same shortest-path/transport code paths—CollisionMap neighbor-expansion logic and PathfinderConfig transport filtering/refresh.
  • chsami/Microbot#1751: Modifies transport handling/pathfinding internals including CollisionMap, Rs2Walker, and PathfinderConfig transport-related code.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.42.1)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants