Refactor file type check (lazy and only 1024 bytes) #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chshersh
added
type: refactoring
chshersh
reviewed
Jan 27, 2025
Owner
chshersh
left a comment
chshersh
left a comment
There was a problem hiding this comment.
That pretty much implements exactly how I wanted it to be implemented!
I left only a couple of minor comments.
Collaborator
Author
|
I think I addressed everything in (8df2944) - also removed some of the helper functions from the module now that the type is simpler. |
chshersh
reviewed
Jan 28, 2025
Owner
chshersh
left a comment
chshersh
left a comment
There was a problem hiding this comment.
Nice simplification!
Noticed one last minor thing but overall looks great!
chshersh
approved these changes
Jan 28, 2025
Owner
chshersh
left a comment
chshersh
left a comment
There was a problem hiding this comment.
Thanks again!
I'm glad the fixed turned out to be relatively simple and short 🙂
Owner
|
Nice fix! Just checked it and it works as expected 🔝 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29 (regression the binary check introduced).
I wasn't sure what the shape of
Filec.tshould be now - so as a first pass I left it but made the other changes suggested in #29.