feat(chat): autoscroll to newest message#4
Merged
Conversation
Co-authored-by: Chaitanya Mittal <chtnnh@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick UX patch: the chat now auto-scrolls to the newest message.
Change
ChatMessagescomponent inemoji-chat.tsxthat owns the scroll container and auto-scrolls to the bottom on new messages — but only when the viewer is already pinned to the bottom (within 48px). If someone scrolls up to re-read history, incoming messages won't yank them back down.room-client.tsxuses<ChatMessages>in place of the inline message list (chat renders in both the desktop sidebar and the mobile tab, so encapsulating the ref avoids a shared-ref collision).Walkthrough
chat_autoscroll_demo.mp4
Sending Message 1→40 keeps the newest message in view; the log overflows (older messages scroll off the top) and scrolling up to read history is uninterrupted.
Newest message pinned at bottom after overflow
Testing
pnpm --filter @together/web typecheckTo show artifacts inline, enable in settings.