Skip to content

Fix NPE when loading players that don't have a skin#1000

Merged
leMaik merged 1 commit intochunky-dev:masterfrom
leMaik:fix-skin-npe
Jun 22, 2021
Merged

Fix NPE when loading players that don't have a skin#1000
leMaik merged 1 commit intochunky-dev:masterfrom
leMaik:fix-skin-npe

Conversation

@leMaik
Copy link
Copy Markdown
Member

@leMaik leMaik commented Jun 22, 2021

This fixes an NPE when loading players without a skin:

Exception in thread "Scene Manager" java.lang.NullPointerException: Cannot invoke "se.llbit.util.mojangapi.PlayerSkin.getUrl()" because "skin" is null
	at se.llbit.chunky.renderer.scene.Scene.loadChunks(Scene.java:909)
	at se.llbit.chunky.renderer.scene.SynchronousSceneManager.loadChunks(SynchronousSceneManager.java:178)
	at se.llbit.chunky.renderer.scene.AsynchronousSceneManager.lambda$loadChunks$3(AsynchronousSceneManager.java:152)
	at se.llbit.chunky.renderer.scene.AsynchronousSceneManager.run(AsynchronousSceneManager.java:82)

@leMaik leMaik added bug snapshot-only Issues that only affect Chunky snapshots labels Jun 22, 2021
@leMaik leMaik merged commit 8df5487 into chunky-dev:master Jun 22, 2021
@leMaik leMaik deleted the fix-skin-npe branch June 22, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug snapshot-only Issues that only affect Chunky snapshots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant