-
Notifications
You must be signed in to change notification settings - Fork 79
Separate Lectern and Book to match enchantment tables and its book #1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Separate Lectern and Book to match enchantment tables and its book #1376
Conversation
|
Lecterns are entities only because they are bigger than a block, i.e. they would be block entities. But then there's the book, which must be an entity (an actor) so that it can be posed. Having a block entity and an entity at the same time would help, but I guess returning collections helps make this future-proof? |
|
Yeah that was my thinking, if you'd like me to implement it differently let me know |
6d69f85 to
5a0cd3e
Compare
|
@NotStirred I rebased this on top of As a follow-up PR, we could add a button to create a book entity from a lectern, right now adding a lectern creates an empty lectern and not one with a book. |
|
Should we rename the |
|
Yeah that's probably better 👍 |
Lecterns are no longer poseable Lecterns now return both the lectern and its book.
…reate entities or block entities from blocks that don't support this.
…o clarify how entities and block entities work.
5a0cd3e to
bf2f67e
Compare
|
Rebased, renamed methods and added more javadoc. Having |
Previously a lectern redirected all pose information to its child book, which is different to the enchantment table. Likely because both lectern and book are entities
Main changes in this PR:
toEntityandfromJsonrespectivelyAs a result, lecterns don't show up in the entities list (as they shouldn't), and lectern books show up in the entities list