Skip to content

add missing return type hints#2

Merged
chx merged 1 commit intochx:mainfrom
ptmkenny:return_types
Apr 24, 2025
Merged

add missing return type hints#2
chx merged 1 commit intochx:mainfrom
ptmkenny:return_types

Conversation

@ptmkenny
Copy link
Copy Markdown
Contributor

@ptmkenny ptmkenny commented Oct 3, 2024

Thanks for making it easy to create forks of modules!

Return type hints needs to be added for Symfony 7 compatibility. My CI builds (in PlatformSH) are failing with this error:

Return type declaration must be compatible with Command->execute(input: \Symfony\Component\Console\Input\InputInterface, output: \Symfony\Component\Console\Output\OutputInterface) : int

This PR adds the missing return type hints.

@chx chx merged commit 424106b into chx:main Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants