Skip to content

Conversation

@bertdeblock
Copy link
Contributor

  • ember-lifeline is unmaintained, and is already triggering deprecation warnings in newer Ember versions
  • The recommendation to use it is outdated, see this issue
  • ember-basic-dropdown is widely used, so the less dependencies the better

@bertdeblock
Copy link
Contributor Author

Will look into the failures asap. Sounds like something is not awaited properly, or I need to re-add a runloop call somewhere. Not sure why it only fails for beta and canary though.

@mkszepp
Copy link
Collaborator

mkszepp commented Sep 5, 2025

@bertdeblock can you maybe tell me in which version you are getting warnings from from ember-lifeline? I have right now all apps on 6.6 (embroider with vite and webpack) and we don't see deprecation warnings for this... and looking release notes from 6.7 there was no deprecation introduced 🤔 https://github.com/emberjs/ember.js/releases/tag/v6.7.0-ember-source

Is this deprecation starting with a beta or canary?

At all its good to remove this package, when this is not anymore maintained.

@bertdeblock
Copy link
Contributor Author

ember-lifeline imports from ember => https://github.com/ember-lifeline/ember-lifeline/blob/master/packages/ember-lifeline/src/utils/get-timeout-or-test-fallback.ts#L1, which should trigger the barrel file deprecation.

@bertdeblock
Copy link
Contributor Author

bertdeblock commented Sep 5, 2025

More specifically, this one => https://deprecations.emberjs.com/id/deprecate-import-testing-from-ember/

@bertdeblock
Copy link
Contributor Author

bertdeblock commented Sep 8, 2025

It seems the failures happen on master as well => https://github.com/bertdeblock/ember-basic-dropdown/actions/runs/17544744717, so maybe it's some kind of regression in ember-source itself.

Asked on Discord.

@bertdeblock bertdeblock force-pushed the remove-use-of-ember-lifeline branch from dfa9093 to b0809b4 Compare September 12, 2025 08:43
@bertdeblock
Copy link
Contributor Author

Seems beta hasn't received the fix yet, will ask on Discord.

@mkszepp
Copy link
Collaborator

mkszepp commented Sep 12, 2025

LGTM! thank you... for merging i would just wait , until fix is released in ember-beta if it's okay

@bertdeblock
Copy link
Contributor Author

@mkszepp Sure, no problem. Thanks for the review!

@mkszepp mkszepp merged commit 2b9d1b1 into cibernox:master Sep 16, 2025
39 of 40 checks passed
@mkszepp
Copy link
Collaborator

mkszepp commented Sep 16, 2025

@bertdeblock released in v8.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants