Convert addon to gts #1005
Merged
Convert addon to gts #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving addon to gts is not breaking and helps us to ensure that all types are correctly inside addon. The addon is now converted into strict template mode.
There were some types defined as
stringinstead exact type. It's possible that app are getting typing error, when it was not used correctly.Types which were used over more files were moved from component files into
types.tsfile, but we are keeping typing exports to avoid breaking changes. Internal we are using already all types fromtypes.ts... its planned to remove the reexports in an major.After merging this changes, the addon is ready for glint v2