Skip to content

Types: Separate Args and Signature #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkszepp merged 1 commit into from
Jan 8, 2024
Merged

Types: Separate Args and Signature #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions ember-basic-dropdown/src/components/basic-dropdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,15 @@ export interface Dropdown {
const UNINITIALIZED = {};
const IGNORED_STYLES = ['top', 'left', 'right', 'width', 'height'];

interface Args {
interface BasicDropdownSignature {
Element: HTMLElement;
Args: BasicDropdownArgs;
Blocks: {
default: [api: Dropdown];
};
}

interface BasicDropdownArgs {
initiallyOpened?: boolean;
renderInPlace?: boolean;
verticalPosition?: string;
Expand All @@ -54,9 +61,6 @@ interface Args {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
contentComponent: string | ComponentLike<any>;
calculatePosition?: CalculatePosition;
Blocks: {
default: [api: Dropdown];
};
}

type RepositionChanges = {
Expand All @@ -70,7 +74,7 @@ type RepositionChanges = {
height?: string | undefined;
};

export default class BasicDropdown extends Component<Args> {
export default class BasicDropdown extends Component<BasicDropdownSignature> {
@tracked hPosition: string | null = null;
@tracked vPosition: string | null = null;
@tracked top: string | undefined;
Expand Down Expand Up @@ -138,7 +142,7 @@ export default class BasicDropdown extends Component<Args> {
}

// Lifecycle hooks
constructor(owner: Owner, args: Args) {
constructor(owner: Owner, args: BasicDropdownArgs) {
super(owner, args);
if (this.args.onInit) {
this.args.onInit(this.publicAPI);
Expand Down