Skip to content

Conversation

@dagroe
Copy link
Contributor

@dagroe dagroe commented Feb 7, 2025

This adds two missing exports for BasicDropdown. These exports help, e.g., to correctly reference and type the Dropdown's blocks in components re-yielding the BasicDropdown blocks.

@dagroe
Copy link
Contributor Author

dagroe commented Feb 13, 2025

@mkszepp Could you review this or maybe ping someone else for review?

@mkszepp
Copy link
Collaborator

mkszepp commented Feb 13, 2025

@dagroe sry, didn't f ound time right now...

I have seen your using in power datepicker and i would suggest following:

Extract this part to an interface, so the code in power datepicker... is more clear and we don't need to access with [0]...

{
        uniqueId: string;
        disabled: boolean;
        isOpen: boolean;
        actions: DropdownActions;
        Trigger: ComponentLike<BasicDropdownTriggerSignature>;
        Content: ComponentLike<BasicDropdownContentSignature>;
}

Could you update this in this PR?

@dagroe
Copy link
Contributor Author

dagroe commented Feb 14, 2025

Hey @mkszepp good idea, thanks. I updated this PR.

Copy link
Collaborator

@mkszepp mkszepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@mkszepp mkszepp changed the title Export BasicDropdownSignature and BasicDropdownArgs for BasicDropdown Export interfaces BasicDropdownSignature, BasicDropdownArgs and BasicDropdownDefaultBlock Feb 16, 2025
@mkszepp mkszepp merged commit c8a4c67 into cibernox:master Feb 16, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants